[wp-trac] [WordPress Trac] #18026: stripslashes_deep() casts booleans to strings

WordPress Trac wp-trac at lists.automattic.com
Tue Jul 10 14:12:39 UTC 2012


#18026: stripslashes_deep() casts booleans to strings
------------------------------+------------------
 Reporter:  DemoIgor          |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.5
Component:  Formatting        |     Version:  3.2
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by westi):

 Replying to [comment:11 nacin]:
 > Since we use stripslashes_deep() quite a bit in core, I'm trying to
 think of the potential side effects. For one, an update_option() of two
 equal serialized values (that are no longer equal due to the change here)
 would force an update. I don't see this as a big problem, but something to
 keep in mind. A deploy to WP.com for instance might cause a spike in
 writes.

 This patch looks good to me too.

 The possibly wide reaching effect is a bit of a worry but no one should be
 updating options from most requests anyway so I don't think it would have
 too much of an effect.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18026#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list