[wp-trac] [WordPress Trac] #13757: Passing functions as call by ref parameter should be avoided

WordPress Trac wp-trac at lists.automattic.com
Wed Jan 25 11:38:55 UTC 2012


#13757: Passing functions as call by ref parameter should be avoided
------------------------------+-----------------------------
 Reporter:  TobiasBg          |       Owner:  westi
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  Future Release
Component:  Warnings/Notices  |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch         |
------------------------------+-----------------------------
Changes (by TobiasBg):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Closing this as "fixed somewhere along the road".

 I grep'd again, and the only find was something like this in atomlib.php:
 {{{
 $tag = array_pop(split(":", $name));
 }}}
 But since that's an external lib, I'm not sure if we'll mess with it at
 all. And as the split() (deprecated in PHP 5.3.0) would need to be
 replaced by explode() anyway, this can then be dealt with together.

 New occurances of PHP warnings/notices related to function calls being
 used as a call-by-ref parameter should get a new ticket.

 P.S.: Someone could change the Milestone again, if necessary, probably to
 3.2. (I seem to lack permissions for that.)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13757#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list