[wp-trac] [WordPress Trac] #19876: generate_rewrite_rules() for posts/pages should set $paged and $walk_dirs false

[WordPress Trac]

#19876: generate_rewrite_rules() for posts/pages should set $paged and $walk_dirs
false
---------------------------+-----------------------------
 Reporter:  duck_          |      Owner:
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Rewrite Rules  |    Version:
 Severity:  normal         |   Keywords:  has-patch
---------------------------+-----------------------------
 The default value of true for these two flags results in extra,
 nonsensical rules for these permastructs.

 ----

 $walk_dirs = true indicates that a loop should be run through each
 component (separated by /) of the permastruct with rules being built for
 each level in turn.

 The purpose of walking through the directory structure is to build pretty
 permalinks for date archives and was introduced in [1373]. [1374] started
 the shift to the code structure we have today with rewrite_rules() calling
 generate_rewrite_rules() for different structs, but continued to do the
 walk for the post structure and only did a separate call for date archives
 if %year%, %monthnum% and %day% weren't all in the permalink structure.
 Finally [1868] started always generating the date permalinks, but left in
 the directory walking for post permalinks.

 This leads to duplicated effort - date permalinks don't need to be
 generated twice.

 It also causes endpoints to be applied in too many locations, e.g. set
 permalink structure to "%category%/%postname%/" and set up an endpoint for
 permalinks:

 {{{
 add_rewrite_endpoint( 'foo', EP_PERMALINK );
 }}}

 Notice that the endpoint rewrite not only gets added to the end of the
 single post rule but also:

 {{{
 "(.+?)/foo(/(.*))?/?$" =>
 "index.php?category_name=$matches[1]&foo=$matches[3]"
 }}}

 which is a rewrite to a category archive and not a permalink.

 For the same reason as above (the $ep_mask, EP_PERMALINK, passed as an
 argument doesn't apply to all the 'directories' being walked over) you
 also get strange rules like:

 {{{
 "(.+?)/comment-page-([0-9]{1,})/?$" =>
 "index.php?category_name=$matches[1]&cpage=$matches[2]"
 }}}

 Comment pages for a category archive?

 ----

 $paged = true indicates that the archive style pagination rule
 (`/page/[0-9]+/`) should be added. This leads to an extra rule, for
 example:

 {{{
 '([0-9]{4})/([0-9]{1,2})/([^/]+)/page(/?[0-9]+)/?$' =>
 'index.php?year=$matches[1]&monthnum=$matches[2]&name=$matches[3]&paged=$matches[4]'
 }}}

 That style of pagination is for archives and not single posts or pages
 which use `<permalink>/[0-9]+/`.

 This extra pagination rule was introduced for posts in [1373] (to allow
 for pretty pagination for date archives) and for pages in [2146].

 ----

 One reason against the change that I can think of is that these rules have
 been around for so long somebody might expect them to be there.

 There are also some situations which currently work when really I don't
 think they should.

  * !http://example.com/uncategorized/ (without the category base) works
 and currently isn't redirected by canonical (#18734). With the patch it
 would 404.
  * !http://example.com/2012/hello-world/page/2/ works as it is redirected
 by canonical to !http://example.com/2012/hello-world/, but with the patch
 it would 404.

 ----

 Related #17185

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19876>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software