[wp-trac] [WordPress Trac] #19854: themes.php doesn't show child themes if using Mac-style CR EOL markers

WordPress Trac wp-trac at lists.automattic.com
Sat Jan 21 06:21:12 UTC 2012


#19854: themes.php doesn't show child themes if using Mac-style CR EOL markers
--------------------------+------------------------------
 Reporter:  novasource    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Themes        |     Version:  3.3.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------
Changes (by solarissmoke):

 * keywords:   => has-patch


Comment:

 This happens with plugins also.

 Tracked it down to the regex in `get_file_data()`. The line start/end
 metacharacters (`^` and `$`) require a `LF` (`\n`) in order to detect the
 start/end of a line - which of course isn't there if you just have `CR`
 (`\r`). Fix seems relatively simple.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19854#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list