[wp-trac] [WordPress Trac] #19767: Password Reset email returns invalid account address

[WordPress Trac]

#19767: Password Reset email returns invalid account address
--------------------------+------------------------------
 Reporter:  raamdev       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  1.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by raamdev):

 Replying to [comment:2 dd32]:
 > Replacing the usage of `network_site_url()` with
 `trailingslashit(network_home_url())` sounds correct here to me
 >
 > Currently it returns `http://dd32.id.au/wordpress` where as I'd expect
 `http://dd32.id.au/`
 >
 > We've always used the siteurl in this field however, for the last 7
 years at least :)

 Replacing {{{network_site_url()}}} with
 {{{trailingslashit(network_home_url())}}} wouldn't correct the problem.
 That would simply return {{{http://dd32.id.au/wordpress/}}} not
 {{{http://dd32.id.au/}}} as you said you'd expect.

 What doesn't make sense to me is why you'd ever want to show the
 !WordPress Address to a user resetting their password. If !WordPress
 Address and Site Address are different, the !WordPress Address points
 nowhere useful to the user (only <!WordPress Address>/wp-admin/ is useful,
 but a user probably shouldn't be pointed there either).

 It seems like {{{network_home_url()}}} (if multisite) or {{{home_url()}}}
 (if non-multisite) would be the logical thing to use. Am I missing
 something?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19767#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software