[wp-trac] [WordPress Trac] #20116: Welcome User Email in Multisite Can't Be Changed

[WordPress Trac]

#20116: Welcome User Email in Multisite Can't Be Changed
--------------------------+------------------
 Reporter:  Ipstenu       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4
Component:  Multisite     |     Version:  3.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by SergeyBiryukov):

 * keywords:   => has-patch
 * milestone:  Awaiting Review => 3.4


Comment:

 It's 'Dear User' indeed, but I guess Ipstenu refers to
 `welcome_user_email` option:
 http://core.trac.wordpress.org/browser/tags/3.3.1/wp-includes/ms-
 functions.php#L1897

 I can reproduce the bug in trunk. Seems introduced in [18588].

 Since default `welcome_user_email` is implemented via a filter,
 `update_site_option()` doesn't call `add_site_option()` and then fails to
 update a non-existing option.

 We should get rid of `welcome_user_msg_filter()` and make
 `welcome_user_email` a proper option, like `welcome_email`.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20116#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software