[wp-trac] [WordPress Trac] #19810: Autocomplete for users and sites in Network admin

WordPress Trac wp-trac at lists.automattic.com
Thu Feb 16 15:15:26 UTC 2012


#19810: Autocomplete for users and sites in Network admin
------------------------------+------------------
 Reporter:  markjaquith       |       Owner:
     Type:  task (blessed)    |      Status:  new
 Priority:  high              |   Milestone:  3.4
Component:  Multisite         |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by duck_):

 Added [attachment:19810.site-admin-logic.diff] to fix some brokenness with
 the `autocomplete_users_for_site_admins` filter.

 In wp-admin/includes/ajax-actions.php a site admin can perform the user
 search even without any filters being added because we're missing "!".
 Also wrapped the `&&` clause in parens for clarity.

 In wp-admin/user-new.php added parens around the `||` clause to combat
 `&&` vs. `||` precedence. Currently it's possible for the script to be
 loaded on single site if someone has added `add_filter(
 'autocomplete_users_for_site_admins', '__return_true' );`... stupid, but
 it shouldn't happen.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19810#comment:50>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list