[wp-trac] [WordPress Trac] #18429: Create custom post types via XMLRPC
WordPress Trac
wp-trac at lists.automattic.com
Wed Feb 1 12:47:35 UTC 2012
#18429: Create custom post types via XMLRPC
----------------------------+------------------------
Reporter: nprasath002 | Owner: westi
Type: task (blessed) | Status: reviewing
Priority: normal | Milestone: 3.4
Component: XML-RPC | Version:
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+------------------------
Comment (by markoheijnen):
I hope I got time to put your feedback into a new patch before the office
hour.
About the use of get_default_post_to_edit. I was in a two fight. Now all
the code is with each other.
Not needing it was my plan but then you split things like the taxonomy
terms. Something that is also ugly in my point of view.
- post_author check can indeed be better. else branch doesn't need absint
because of the user variable.
- I don't know if we should give an error. maybe we do. Curious what westi
thinks about that point
- I will look into the undefined $terms_needed term.
- I will seperate the complex if statement. I don't think we should give
an error when it is invalid.
- Will change blog_ID to blog_id
- I didn't knew at all that there needs to be a spaces around !. Will do
that
The filters sounds as a good idea.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18429#comment:23>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list