[wp-trac] [WordPress Trac] #22790: Duplicating Embed-Codes

WordPress Trac noreply at wordpress.org
Sun Dec 9 23:41:31 UTC 2012


#22790: Duplicating Embed-Codes
--------------------------+---------------------
 Reporter:  Bichareh      |       Owner:  ryan
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  3.5
Component:  TinyMCE       |     Version:  trunk
 Severity:  major         |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by azaozz):

 Replying to [comment:19 WraithKenny]:
 > ...the id attr on object gets removed still for example.

 Been looking why this is still happening. The syntax for adding `embed` as
 a valid child to `object` is different from the syntax for adding valid
 attributes, so we should be doing `addValidChildren('+object[embed]')`
 instead of `addValidChildren('object[*]')`.

 Here is the description of the
 [http://www.tinymce.com/wiki.php/API3:method.tinymce.html.Schema.addValidChildren
 TinyMCE API function], the
 [http://www.tinymce.com/wiki.php/Configuration:valid_children
 `valid_children` init setting] that gets passed directly to that function,
 and an
 [https://github.com/tinymce/tinymce/blob/master/jscripts/tiny_mce/classes/html/Schema.js#L664
 example] of TinyMCE core using it.

 Note: this is a fix for 22790.patch/[23112] to make TinyMCE properly
 recognize <object><embed /></object> tags, it doesn't affect the rest of
 the schema.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22790#comment:32>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list