[wp-trac] [WordPress Trac] #21616: add-textdomain doesn't conform to WP coding standards

[WordPress Trac]

#21616: add-textdomain doesn't conform to WP coding standards
--------------------------+----------------------------
 Reporter:  groovecoder   |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  WordPress.org
Component:  I18N          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+----------------------------

Comment (by groovecoder):

 In fact now that I've looked I don't think this script '''can''' fix the
 opening parenthesis without a space, since token_get_all only knows about
 the '(' character.

 Unless we start keeping '''more''' state during the token loop like:
 {{{
 if ($prev_token == '(' && $token !== ' ') {
     $token = ' ' . $token;
 }
 $prev_token = $token
 }}}
 Right before the `$this->process_token($token, $inplace)` line. But that
 seems like polluting the script with irrelevant functionality.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21616#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software