[wp-trac] [WordPress Trac] #6821: ImageMagick support

[WordPress Trac]

#6821: ImageMagick support
----------------------------+-----------------------
 Reporter:  matt            |       Owner:
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  3.5
Component:  Upload          |     Version:  2.5
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+-----------------------

Comment (by DH-Shredder):

 Replying to [comment:41 scribu]:
 > I do like how saving is a separate method. In the interface that DH-
 Shredder posted, each method has an $output_file parameter, which is not
 very orthogonal.

 I agree that it's not ideal.  It was done because I was having difficulty
 coming up with a design pattern with regards to output that solved all of
 the issues, and would definitely be open to suggestions as to a better way
 to solve the output problem.

 The reason that this wasn't done with a single required save() method for
 output is twofold:
 - I expect that we'll be using the same input image to do multiple
 operations, with output to different filenames.
 - We're moving from holding images in RAM to using input files directly in
 the case of convert/gm, which makes either an output filename or temporary
 file necessary, for changes not done in-place.

 Do you think it'd be better for convert/gm cases to perform all actions to
 a temporary file, then "saved (copied)" to a final destination (whether it
 be on top of the current file, or another location)?  I think, in
 particular for cases where we're thumbnailing, that would probably cause
 more I/O load than we want to do.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/6821#comment:43>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software