[wp-trac] [WordPress Trac] #20508: 3.4 Preview/Customize - "Save and Activate" doesn't save advanced theme settings (eg: 2011)

WordPress Trac wp-trac at lists.automattic.com
Sun Apr 22 01:49:08 UTC 2012


#20508: 3.4 Preview/Customize - "Save and Activate" doesn't save advanced theme
settings (eg: 2011)
--------------------------+------------------
 Reporter:  TomAuger      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4
Component:  Themes        |     Version:  3.4
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------
Changes (by SergeyBiryukov):

 * component:  General => Themes
 * milestone:  Awaiting Review => 3.4


Comment:

 From my testing, this happens when saving theme-specific features (like
 `custom-background`) not supported by current theme (e.g. Carrington 2.2).

 Seems that the settings are saved on `admin_init`, which is after current
 theme mods (or a lack thereof) have been initialized on
 `after_setup_theme`.

 `WP_Customize_Setting::check_capabilities()` then returns false, and the
 new theme mods are not applied in `WP_Customize_Setting::save()`.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20508#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list