[wp-trac] [WordPress Trac] #17976: Make comment_* cookies pluggable

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 30 10:54:57 UTC 2011


#17976: Make comment_* cookies pluggable
-----------------------------------+-----------------------
 Reporter:  pishmishy              |       Owner:  westi
     Type:  feature request        |      Status:  accepted
 Priority:  normal                 |   Milestone:  3.3
Component:  Comments               |     Version:  3.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch westi-likes  |
-----------------------------------+-----------------------

Comment (by SergeyBiryukov):

 Replying to [comment:13 westi]:
 > I think it would be nicer to pass the 'user' object to the action and
 therefore the function rather than relying on the name of a global so that
 the cookie setting is independent of any globals.

 Thanks for the feedback, done in [attachment:17976.4.patch].

 Would it make sense to pass the whole comment object as well, rather than
 call `get_comment()` for the second time? If no, I'll replace it with
 `$comment_id` again.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17976#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list