[wp-trac] [WordPress Trac] #17578: Merge media buttons into one

[WordPress Trac]

#17578: Merge media buttons into one
------------------------------------+------------------
 Reporter:  mitchoyoshitaka         |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  3.3
Component:  Media                   |     Version:
 Severity:  trivial                 |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by nacin):

 The more I look, the more completely dead code I find in wp-
 admin/includes/media.php. Some of it rendered useless by Plupload, others
 over the years.

 media_upload_image(), in the patch, currently handles all "Insert into
 Post" clicks for video/audio/files and images. Only, the image handling
 code is dead. It's unreachable. The form will never submit data back for
 images. It does it via JS. The image_send_to_editor_url hook is thus
 completely dead.

 I found this while doing a full audit of all hooks, using the 'all' hook.
 And I did find we're in good shape here.

 Doing a commit on this, minus the changes for mu_media_buttons (other than
 that they won't hide buttons). Not dealing with function renaming or
 deprecation yet. Will follow up with any breakage in the morning. Have yet
 to grep the plugins repo -- a new slurp is currently in progress. Doing
 the commit mainly so Jane can have it during testing.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17578#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software