[wp-trac] [WordPress Trac] #16539: Duplicate search widgets cause ID conflicts

[WordPress Trac]

#16539: Duplicate search widgets cause ID conflicts
------------------------------------+------------------------------
 Reporter:  solarissmoke            |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Widgets                 |     Version:  3.0
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------------------

Comment (by dd32):

 Just a quick suggestion to reduce the code:
 {{{
 $form_id = 'searchform';
 ...
 if ( !$search_form_counter ) {
    $form_id .= '-' . $search_form_counter;
    ...
 }
 }}}

 > so that's why there's a dupe

 Not sure if there's any differences between the 2, however, you shouldn't
 ever need to use the overwrite function, only use that when there's a need
 to replace the patch (ie. You accidentally included wp-config in it), we
 like to see the various stages in the patches (and have a reference for
 the comments to a original patch)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16539#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software