[wp-trac] [WordPress Trac] #18975: [E_STRICT] menu.php at line 218

[WordPress Trac]

#18975: [E_STRICT] menu.php at line 218
------------------------------------+-----------------------
 Reporter:  arena                   |       Owner:
     Type:  defect (bug)            |      Status:  reopened
 Priority:  normal                  |   Milestone:  3.3
Component:  Menus                   |     Version:  3.3
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------
Changes (by scribu):

 * keywords:  dev-feedback needs-patch => dev-feedback has-patch


Comment:

 Yep, the difference in performance between array_shift() and array_pop()
 vs. reset() and end() is unnoticeable, even for arrays with thousands of
 items.

 So [attachment:18975.4.patch] is just a single conversion to key(), since
 I think it makes the code easier to understand.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18975#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software