[wp-trac] [WordPress Trac] #19029: Delete Permanently comments one by one in Spams or Trash increases counter

WordPress Trac wp-trac at lists.automattic.com
Tue Oct 25 19:45:28 UTC 2011


#19029: Delete Permanently comments one by one in Spams or Trash increases counter
--------------------------+------------------------------
 Reporter:  hebbet        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Comments      |     Version:  3.0.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------
Changes (by duck_):

 * keywords:  needs-patch => has-patch


Comment:

 Attached [attachment:19029.diff].

 The fix for the bug described is the logic change to updating the total
 value at the bottom. We want to decrement the displayed total unless a
 trash/spam is being undone.

 Also removed the `span.total-type-count` update code as "total-type-count"
 isn't referenced anywhere else in WordPress core. The total updates now
 take place inline using `.displaying-num`. Updated the comment
 accompanying updateTotalCount() accordingly.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19029#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list