[wp-trac] [WordPress Trac] #18448: wp_insert_category() is Not Properly Abstracted

WordPress Trac wp-trac at lists.automattic.com
Sat Oct 8 16:47:53 UTC 2011


#18448: wp_insert_category() is Not Properly Abstracted
-------------------------------------+------------------------------
 Reporter:  miqrogroove              |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Taxonomy                 |     Version:  3.0
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |
-------------------------------------+------------------------------
Changes (by Dvvarf):

 * keywords:  needs-patch => needs-testing has-patch


Comment:

 The patch replaces all calls to wp_insert_category with calls to
 corresponding term functions. wp_insert_category, however, had $wp_error
 argument, that was used to suppress returning WP_Error, so I added it to
 wp_insert_term and wp_update_term functions. Any opinions on this
 approach?
 P.S. First patch. =)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18448#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list