[wp-trac] [WordPress Trac] #18289: Direct link to plugin installation should have admin chrome

[WordPress Trac]

#18289: Direct link to plugin installation should have admin chrome
-------------------------------------+------------------------
 Reporter:  nacin                    |       Owner:  nacin
     Type:  task (blessed)           |      Status:  reviewing
 Priority:  normal                   |   Milestone:  3.3
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------
Changes (by dd32):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 > attachment 18289.5.diff  added
  * Midnight patch
  * Thickbox requests get a iframe'd version, direct access gets a full
 admin chrome
  * Revealed a bug in the JS, looks like the Thickbox wasn't getting it's
 custom title from the plugins page thanks to the list tables using a
 different table class
  * Had to switch from body_id (which only the iframe handler supports it
 seems) to a generic body class which is better anyway
  * Doesn't do any Ajax magic like the other patches here
  * Aims for minimal disruption of existing code
  * Seems to work, but needs some extra testing and eyes

 Lets not go into doing any UI+UX overhauls/changes here, All
 install/update functionality needs a facelift, and that needs some thought
 put into it, I don't think we should go through attempting any of that
 here

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18289#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software