[wp-trac] [WordPress Trac] #19136: Secondary items should be a flag for the admin bar

WordPress Trac wp-trac at lists.automattic.com
Wed Nov 23 17:04:02 UTC 2011


#19136: Secondary items should be a flag for the admin bar
--------------------------+--------------------------
 Reporter:  nacin         |       Owner:  koopersmith
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.3
Component:  Admin Bar     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+--------------------------
Changes (by koopersmith):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 There are a bunch of issues with the secondary flag. The main problem is
 that in the case of a secondary menu, setting a flag on each item is far
 worse than having one common parent.

 A good example use case is BuddyPress — BP adds a top level admin bar
 menu, and provides plugins with a variable to implement their own
 submenus. If BP wanted to change its menu to become a secondary component
 of another menu, it would have to update every submenu item with the
 secondary flag (instead of just changing the parent). The larger issue
 here is plugins: every single plugin that added a BuddyPress admin submenu
 would have to update their items with the secondary flag.

 The ideal solution is using groups, which would allow us to split submenus
 into sections. In the case of the BuddyPress menu, it could be converted
 to a group and be easily styled. No plugins would have to be updated, as
 the parent ID would still work.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19136#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list