[wp-trac] [WordPress Trac] #17358: in_admin_footer shouldn't be in p.alignleft

WordPress Trac wp-trac at lists.automattic.com
Tue May 10 17:32:55 UTC 2011


#17358: in_admin_footer shouldn't be in p.alignleft
------------------------------------+------------------
 Reporter:  aaroncampbell           |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  3.2
Component:  Administration          |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by aaroncampbell):

 There are 79 plugins in the repository that use this hook.  *None* of them
 would break if we moved it.  The worst case scenario actually affects
 nearly all of them (70ish) and would be that their text/links would be
 styled differently in the footer because they're no longer in the p tag.
 Here's a list of all of them:

 * Everything would still work, but the text and links (mostly "this site
 is running version ____ of ____" type attribution links, some of them
 asking for donations or linking to wishlists) would be in the div not the
 p so the style would be a little different:
  * [http://wordpress.org/extend/plugins/memepost/ Memepost]
  * [http://wordpress.org/extend/plugins/reveal-ids-for-wp-admin-25/ Reveal
 IDs]
  * [http://wordpress.org/extend/plugins/admin-menus-fixed/ Admin Menus
 Fixed]
  * [http://wordpress.org/extend/plugins/similar-posts/ Similar Posts]
  * [http://wordpress.org/extend/plugins/feedcache-pipes/ FeedCache Pipes]
  * [http://wordpress.org/extend/plugins/role-scoper/ Role Scoper]
  * [http://wordpress.org/extend/plugins/bulk-delete/ Bulk Delete]
  * [http://wordpress.org/extend/plugins/ozh-admin-drop-down-menu/ Ozh'
 Admin Drop Down Menu]
  * [http://wordpress.org/extend/plugins/random-posts-plugin/ Random Posts]
  * [http://wordpress.org/extend/plugins/secure-wordpress/ Secure
 WordPress]
  * [http://wordpress.org/extend/plugins/floating-social-media-buttons/ tbk
 Creative's Social Float]
  * [http://wordpress.org/extend/plugins/syntaxhighlighter-tinymce-button/
 SyntaxHighlighter TinyMCE Button]
  * [http://wordpress.org/extend/plugins/custom-upload-dir/ Custom Upload
 Dir]
  * [http://wordpress.org/extend/plugins/quiz/ Quiz]
  * [http://wordpress.org/extend/plugins/ideascale/ IdeaScale]
  * [http://wordpress.org/extend/plugins/exhibit-to-wp-gallery/ Exhibit to
 WP Gallery]
  * [http://wordpress.org/extend/plugins/smooth-gallery-replacement/ Smooth
 Gallery Replacement]
  * [http://wordpress.org/extend/plugins/gigpress/ GigPress]
  * [http://wordpress.org/extend/plugins/wp-simpleviewer/ WP-SimpleViewer]
  * [http://wordpress.org/extend/plugins/recent-posts-plugin/ Recent Posts]
  * [http://wordpress.org/extend/plugins/ozh-better-feed/ Ozh' Better Feed]
  * [http://wordpress.org/extend/plugins/easy-retweet/ Easy retweet ]
  * [http://wordpress.org/extend/plugins/graceful-pull-quotes/ Graceful
 Pull-Quotes]
  * [http://wordpress.org/extend/plugins/last-modified-footer/ Last
 Modified Footer]
  * [http://wordpress.org/extend/plugins/liz-comment-counter-by-ozh/ Liz
 Comment Counter by Ozh]
  * [http://wordpress.org/extend/plugins/audio-player/ Audio Player]
  * [http://wordpress.org/extend/plugins/fbfoundations-facebook-chicklet/
 FBFoundations Facebook Chicklet]
  * [http://wordpress.org/extend/plugins/popular-posts-plugin/ Popular
 Posts]
  * [http://wordpress.org/extend/plugins/email-log/ E-Mail Log]
  * [http://wordpress.org/extend/plugins/audio-player-oogiechetos/ Audio
 Player]
  * [http://wordpress.org/extend/plugins/recent-comments-plugin/ Recent
 Comments]
  * [http://wordpress.org/extend/plugins/gd-press-tools/ GD Press Tools] -
 Optionally outputs some stats as well as the attribution links
  * [http://wordpress.org/extend/plugins/micropoll/ MicroPoll]
  * [http://wordpress.org/extend/plugins/copyfeed/ ©Feed]
  * [http://wordpress.org/extend/plugins/feedcache/ Feed Cache]
  * [http://wordpress.org/extend/plugins/github-ribbon/ Github Ribbon]
  * [http://wordpress.org/extend/plugins/k2-style-switcher/ K2 Style
 Switcher]
  * [http://wordpress.org/extend/plugins/new-user-email-set-up/ New User
 E-Mail Setup]
  * [http://wordpress.org/extend/plugins/google-document-embedder/ Google
 Doc Embedder]
  * [http://wordpress.org/extend/plugins/facebook-fb-share-wordpress-
 plugin/ FB Share]
  * [http://wordpress.org/extend/plugins/category-icons/ Category Icons]
  * [http://wordpress.org/extend/plugins/repostme-icon-bar/ Repost.Me Icon
 Bar]
  * [http://wordpress.org/extend/plugins/wp-dtree-30/ WP-dTree]
  * [http://wordpress.org/extend/plugins/twitter-avatar-reloaded/ Twitter
 Avatar Reloaded]
  * [http://wordpress.org/extend/plugins/wp-irc/ wp-irc]
  * [http://wordpress.org/extend/plugins/bulk-move/ Bulk Move]
  * [http://wordpress.org/extend/plugins/fluency-admin/ Fluency Admin]
  * [http://wordpress.org/extend/plugins/audiencc/ WP Audiencc]
  * [http://wordpress.org/extend/plugins/wpeasystats/ WP Easy Stats]
  * [http://wordpress.org/extend/plugins/member-access/ Member Access]
  * [http://wordpress.org/extend/plugins/wp-yearendstats/ WP Year End
 Stats]
  * [http://wordpress.org/extend/plugins/wp-footer-ad/ WP Footer Ad]
  * [http://wordpress.org/extend/plugins/cleverness-to-do-list/ Cleverness
 To-Do List]
  * [http://wordpress.org/extend/plugins/addquicktag/ AddQuicktag]
  * [http://wordpress.org/extend/plugins/feedstats-de/ FeedStats]
  * [http://wordpress.org/extend/plugins/wp-jquery-lightbox/ WP jQuery
 Lightbox]
  * [http://wordpress.org/extend/plugins/typekit/ Typekit plugin for
 WordPress]
  * [http://wordpress.org/extend/plugins/simple-yearly-archive/ Simple
 Yearly Archive]
  * [http://wordpress.org/extend/plugins/calendar-press/ CalendarPress]
  * [http://wordpress.org/extend/plugins/occasions/ Occasions]
  * [http://wordpress.org/extend/plugins/js-antispam/ JS AnsiSpam]
  * [http://wordpress.org/extend/plugins/open-flash-chart-core-wordpress-
 plugin/ open-flash-chart-core]
  * [http://wordpress.org/extend/plugins/tweetbacks-helper/ Tweetbacks
 Helper]
  * [http://wordpress.org/extend/plugins/lim4wp/ Lim4wp]
  * [http://wordpress.org/extend/plugins/seo-booster-lite/ SEO Booster
 Lite]
  * [http://wordpress.org/extend/plugins/adminimize/ Adminimize]
  * [http://wordpress.org/extend/plugins/wpprosperent/ WP Prosperent
 Plugin]
  * [http://wordpress.org/extend/plugins/text-control-2/ Text Control]
  * [http://wordpress.org/extend/plugins/seo-ultimate/ SEO Ultimate]
  * [http://wordpress.org/extend/plugins/geo-mark/ Geo Mark]
 * Just removes the browse_happy hook which already doesn't exist
  * [http://wordpress.org/extend/plugins/super-switch/ Super Switch]
 * Uses it as a checkpoint where it checks and reports runtime
  * [http://wordpress.org/extend/plugins/debug-bar-extender/ Debug-Bar-
 Extender]
 * Would actually benefit from the change
  * [http://wordpress.org/extend/plugins/paypal-digital-goods-monetization-
 powered-by-cleeng/ PayPal Digital Goods powered by Cleeng] - Outputs a
 form wrapped in a div
  * [http://wordpress.org/extend/plugins/aioseo-multibyte-descriptions/
 Aioseo Multibyte Descriptions] - Displays messages in p tags wrapped in
 divs
  * [http://wordpress.org/extend/plugins/cleeng/ Cleeng Content
 Monetization] - Outputs a form wrapped in a div
 * Just includes another plugin:
  * [http://wordpress.org/extend/plugins/moonvipercmscom/ Dashboard Editor]
 - Seems to just include [http://wordpress.org/extend/plugins/ozh-admin-
 drop-down-menu/ Ozh' Admin Drop Down Menu] which is already listed above
 * Actually uses it:
  * [http://wordpress.org/extend/plugins/show-svn-revision/ Show SVN
 Revision] - Just displays some text and links showing you what svn
 revision you're running *if* it can access
  * [http://wordpress.org/extend/plugins/wp-cache-inspect/ WP Cache
 Inspect] - Adds a cache flush link
  * [http://wordpress.org/extend/plugins/wp-syntaxhighlighter/ WP
 SyntaxHighlighter] - Includes JS

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17358#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list