[wp-trac] [WordPress Trac] #8622: HTTP API Fallover & non-blocking order doesnt appear to be working

WordPress Trac wp-trac at lists.automattic.com
Sun Mar 27 00:07:19 UTC 2011


#8622: HTTP API Fallover & non-blocking order doesnt appear to be working
------------------------------------------+-----------------------------
 Reporter:  DD32                          |       Owner:  jacobsantos
     Type:  defect (bug)                  |      Status:  reopened
 Priority:  normal                        |   Milestone:  Future Release
Component:  HTTP                          |     Version:  2.7
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch tested 2nd-opinion  |
------------------------------------------+-----------------------------

Comment (by nacin):

 Replying to [comment:22 dd32]:
 > It's a design problem for unit testing that you have to filter which
 transport to use, it however, is not a design problem for users of the API
 as they should never attempt to (or have a need to) use a transport
 directly.

 +1. Often it is difficult to test code properly due to how it is
 architected, but that doesn't mean the code is at fault. This is exactly
 how the class should be tested, given its structure.

 > To add fallover and enabled by default will increase the timeouts that
 users experience.
 > Whilst a user should never be waiting on a HTTP request to complete in
 general, we do force that upon them in the Updaters/Installers as well as
 a few other locations related to media. To wait for all the transports (or
 a 2nd transport) to fail in many cases would lead to a bad user experience
 ("Its Slow!")

 Consistent failures are going to be more common, and falling over in a
 non-persistent way doesn't make much sense from the performance aspect.
 Ideally we should be deciding which transport to use and use it, not using
 each transport until one decides to work.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8622#comment:23>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list