[wp-trac] [WordPress Trac] #16695: quicktags needs some refactoring

WordPress Trac wp-trac at lists.automattic.com
Thu Mar 24 18:03:37 UTC 2011

#16695: quicktags needs some refactoring
 Reporter:  garyc40                           |       Owner:  scribu
     Type:  enhancement                       |      Status:  reviewing
 Priority:  normal                            |   Milestone:  Awaiting
Component:  Editor                            |  Review
 Severity:  normal                            |     Version:  3.1
 Keywords:  has-patch dev-feedback 3.2-early  |  Resolution:

Comment (by garyc40):

 Replying to [comment:11 scribu]:
 > Would you still be able to manipulate the button list array (remove, re-
 Yes you would after I provide back compat.

 > Having two methods of doing the exact same thing is not a good idea.
 Which 2 methods, and which same thing?

 > I think a better approach would be to wrap everything in a closure and
 just expose edButtons and edButton, with an additional callback argument.
 In my patch, all the things that should be private are already in a
 closure. Only QuickTags class and public classes that belong to that
 namespace are exposed.

Ticket URL: <http://core.trac.wordpress.org/ticket/16695#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list