[wp-trac] [WordPress Trac] #16858: Usage of HTTP_HOST in the administration

WordPress Trac wp-trac at lists.automattic.com
Thu Mar 24 11:35:27 UTC 2011

#16858: Usage of HTTP_HOST in the administration
 Reporter:  amirhabibi                   |       Owner:
     Type:  defect (bug)                 |      Status:  reopened
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Administration               |     Version:  3.1
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |

Comment (by hakre):

 Replying to [comment:12 dd32]:
 > I don't see a need for these links to be absolute url's, most links in
 the !WordPress admin are relative (ie. just `edit.php?..`)

 I don't see it either, had running this quite fine:

 > We should be able to just call add_query_arg() / remove_query_arg()
 without the $url parameter first.

 I like the idea and the patch.

 > However, Looking at the other uses of HTTP_HOST in WordPress, if it's
 not being corrected afterwards, a lot of login related redirections will
 fail as well.

 They mostly do absolute URIs already as far as I know, the ones which do
 not, I put on #16909. Absolute URIs normally resolves through the
 _site_url() which are bound to the setting, not the environment variable
 and therefore safe.

Ticket URL: <http://core.trac.wordpress.org/ticket/16858#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list