[wp-trac] [WordPress Trac] #16751: phpdoc breaks plugins in WP 3.1

WordPress Trac wp-trac at lists.automattic.com
Sat Mar 5 04:10:23 UTC 2011


#16751: phpdoc breaks plugins in WP 3.1
-------------------------+-----------------------
 Reporter:  miqrogroove  |       Owner:
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  3.1.1
Component:  Plugins      |     Version:  3.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Old description:

> function get_file_data() is no longer compatible with most of the headers
> in my plugins.  I've seen some pretty dumb changes in WordPress before,
> but this is the kind that makes me want to not use it again.
>
> Go ahead and close this as not a bug.  I'll just stick with version 2.9.
> :(

New description:

 As of  #15193, some plugin header styles such as those used
 [http://plugins.trac.wordpress.org/browser/simple-
 shortlinks/trunk/shortlinks.php#L12 here] fail to parse correctly
 (Specifically, `@author: Blah`)

 Ideally, we should support PHP-Doc style comment structures for plugin
 headers as well as the "standard" style.

--

Comment (by dd32):

 > "Don't work" means I have a confirmed defect in the plugins screen of
 the dashboard.

 In the future, mentioning the actual problem in the description is best
 practice, and attacking developers for changing something is not ideal
 either. Had you have tested 3.1, or any of your plugin users had tested
 3.1, it would've been identified at the time and fixed.

 As it is, The problem is that @ is unexpected input, and does not fit with
 the WordPres "standard" plugin header, whilst the plugin still "Works"
 it's just the author details are not read correctly, That being said, That
 style of headers is something worth while supporting, as it is, a very
 small percentage of plugins use it, which explains why it was missed in
 the testing.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16751#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list