[wp-trac] [WordPress Trac] #12307: files missing closing php tags

[WordPress Trac]

#12307: files missing closing php tags
-----------------------------+-----------------------------
 Reporter:  washer           |       Owner:  nacin
     Type:  defect (bug)     |      Status:  accepted
 Priority:  lowest           |   Milestone:  Future Release
Component:  General          |     Version:  2.9.2
 Severity:  trivial          |  Resolution:
 Keywords:  has-patch early  |
-----------------------------+-----------------------------

Comment (by RyanMurphy):

 Replying to [comment:18 toscho]:
 > wp-includes/default-filters.php has a blank line after the closing tag.
 Is that intended?

 I don't see a blank line after the closing tag - I do see one between the
 last command and the tag though.

 > I think, we should drop the closing tags. They do not add any value.

 IMO, they do add value, in that you know you have the full file. When I
 was making the patch, I had to look at some of the files in the trac
 browser to make sure I had the full file, because where it ended didn't
 look right.

 If we don't want to use the PHP closing tag, we should at least add a
 comment, like I did with wp-config-sample.php. But right now, the standard
 is to include them.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12307#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software