[wp-trac] [WordPress Trac] #17832: Don't default to random header image rotation when HEADER_IMAGE = ''

[WordPress Trac]

#17832: Don't default to random header image rotation when HEADER_IMAGE = ''
------------------------------+------------------
 Reporter:  ryan              |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.2
Component:  Themes            |     Version:  3.2
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by lancewillett):

 I like the idea of moving towards {{{add_theme_support()}}} instead of the
 definitions, but... I'd argue that the opt-in already exists:
 '''registering multiple header images'''.

 I can't think of a reason (or an existing example in the wild) where a
 theme registers multiple header images but defaults to text only display.
 Did you find a case like that? Seems very much like an edge case.

 See the original discussion and implementation in #17240. I'd originally
 intended to use {{{HEADER_IMAGE}}} value of "random" to trigger this, but
 it seemed like leaving it empty meant the same thing.

 The argument Aaron Campbell made on the original ticket is that the user
 should choose whether to enable random or not, not the theme itself. The
 theme should always have the randomness available if multiple images
 exist.

 To me that's the one thing I don't like about this feature, there isn't a
 way for a theme to enable randomness and turn it off by default and let
 the user choose. It's either on or off from the theme level.

 It's also confusing what purpose {{{define( 'HEADER_IMAGE', '' );}}} would
 serve now.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17832#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software