[wp-trac] [WordPress Trac] #18227: Autosave JS throws and error for post types with disabled title and editor

WordPress Trac wp-trac at lists.automattic.com
Thu Jul 28 19:44:53 UTC 2011


#18227: Autosave JS throws and error for post types with disabled title and editor
--------------------------+------------------------------
 Reporter:  karevn        |       Owner:  azaozz
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Autosave      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by MarcusPope):

 Replying to [comment:2 azaozz]:

 My fix is purely to prevent the JS error that is thrown when editor or
 title support are removed from a post - a fix of that nature should
 definitely happen regardless of autosave's purpose.

 However I also think preventing autosave entirely because those fields
 were not enabled or because they are empty seems like a poor assumption -
 especially so with the advent of custom post types.  Why shouldn't a
 custom post type be allowed to rely on the autosave functionality for
 custom meta properties it has implemented in a save_post action hook?

 Ideally this code would be refactored entirely to check if each feature is
 enabled first before relying on empty post variables as a trigger to skip
 the autosave process.

 But even outside of custom post types, it would still suck to write an
 entire blog post and lose all progress solely because you didn't populate
 the post's title first.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18227#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list