[wp-trac] [WordPress Trac] #16262: Remove AJAX and extendability from list tables

WordPress Trac wp-trac at lists.automattic.com
Thu Jan 20 08:33:17 UTC 2011


#16262: Remove AJAX and extendability from list tables
-----------------------------+-----------------------
 Reporter:  nacin            |       Owner:  nacin
     Type:  task (blessed)   |      Status:  accepted
 Priority:  highest omg bbq  |   Milestone:  3.1
Component:  Administration   |     Version:  3.1
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+-----------------------

Old description:

> We keep discovering new bugs for the AJAX in the list tables. Some
> current ones include issues with pushState (browser history is broken),
> bulk actions URI redirects and resets (which is a worse issue for
> usability than we thought). These strike at the core of the AJAX
> component. These are not easy to address, and will require some new API
> in some cases (such as transients for updated notices).
>
> The leads have discussed this and the decision is to remove AJAX from the
> list tables for 3.1. Without AJAX, the user functionality is unchanged
> from 3.0. This allows the re-architecture to be spread over multiple
> releases.
>
> Considerations:
>
>  1. ~~Don't enqueue the JavaScript.~~
>
>  2. ~~Don't add the ajax nonce fields or any spinners.~~
>
>  3. ~~The top pagination input doesn't work. Solution is to only have the
> pagination input on the top.~~
>
>  4. ~~The search box button shouldn't have a name.~~
>
>  5. ~~Sorting needs to kick back to page one.~~
>
>  6. ~~Remove the filters in get_list_table() and merge get_list_table()
> and require_list_table() into a private _get_list_table(). Mark all
> tables as private.~~
>
>  7. ''Postponed until 3.2.'' ~~The architecture of the list tables needs
> to be reviewed this week for potential changes. Right now it isn't at the
> state where we are comfortable with release, especially when considering
> future requirements for backwards compatibility. By removing the JS for
> 3.1, we can spend the next week getting the classes exactly how we want
> them.~~
>
>  8. ~~edit-comments.dev.js and theme.dev.js both declare list-table a
> dependency. I don't see anything in theme.dev.js, but there are some
> things in edit-comments.dev.js that will need to be neutered.~~
>
>  9. The comment river needs to be fixed.
>
> Patch to follow shortly.

New description:

 We keep discovering new bugs for the AJAX in the list tables. Some current
 ones include issues with pushState (browser history is broken), bulk
 actions URI redirects and resets (which is a worse issue for usability
 than we thought). These strike at the core of the AJAX component. These
 are not easy to address, and will require some new API in some cases (such
 as transients for updated notices).

 The leads have discussed this and the decision is to remove AJAX from the
 list tables for 3.1. Without AJAX, the user functionality is unchanged
 from 3.0. This allows the re-architecture to be spread over multiple
 releases.

 Considerations:

  1. ~~Don't enqueue the JavaScript.~~

  2. ~~Don't add the ajax nonce fields or any spinners.~~

  3. ~~The top pagination input doesn't work. Solution is to only have the
 pagination input on the top.~~

  4. ~~The search box button shouldn't have a name.~~

  5. ~~Sorting needs to kick back to page one.~~

  6. ~~Remove the filters in get_list_table() and merge get_list_table()
 and require_list_table() into a private _get_list_table(). Mark all tables
 as private.~~

  7. ''Postponed until 3.2.'' ~~The architecture of the list tables needs
 to be reviewed this week for potential changes. Right now it isn't at the
 state where we are comfortable with release, especially when considering
 future requirements for backwards compatibility. By removing the JS for
 3.1, we can spend the next week getting the classes exactly how we want
 them.~~

  8. ~~edit-comments.dev.js and theme.dev.js both declare list-table a
 dependency. I don't see anything in theme.dev.js, but there are some
 things in edit-comments.dev.js that will need to be neutered.~~

  9. The comment river needs to be fixed. (Gary working on this, has a
 patch up)

  10. Paging needs to work when using keyboard shortcuts (i.e. pressing J
 at the bottom of page 1, when there is more than one page).

--

Comment (by markjaquith):

 10. Paging needs to work when using keyboard shortcuts (i.e. pressing J at
 the bottom of page 1, when there is more than one page).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16262#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list