[wp-trac] [WordPress Trac] #13961: search query_vars bug when using search base

[WordPress Trac]

#13961: search query_vars bug when using search base
---------------------------------+-----------------------------
 Reporter:  shidouhikari         |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  Future Release
Component:  Query                |     Version:  3.0
 Severity:  normal               |  Resolution:
 Keywords:  3.2-early has-patch  |
---------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:7 dd32]:
 > Do we need to stripslashes it when it's coming from a Permastruct?
 Looks like not. However it doesn't seem to have a difference in this case.

 Replying to [comment:7 dd32]:
 > We probably should also use `$wp_rewrite->using_permastruct` or
 something instead of `empty($_GET)`
 Did you mean `$wp_rewrite->using_permalinks()`? Since a search request can
 come through `$_GET` in this case too (and it does so in Twenty Ten search
 widget, regardless of the permalink structure), I guess `empty($_GET)` is
 a more reliable check.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13961#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software