[wp-trac] [WordPress Trac] #16146: Remove the theme supports check when deciding post format rewrites

WordPress Trac wp-trac at lists.automattic.com
Fri Jan 7 21:21:02 UTC 2011


#16146: Remove the theme supports check when deciding post format rewrites
---------------------------+-----------------
 Reporter:  nacin          |      Owner:
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  3.1
Component:  Rewrite Rules  |    Version:  3.1
 Severity:  normal         |   Keywords:
---------------------------+-----------------
 Currently, when registering the post_format taxonomy, we check
 current_theme_supports('post-formats').

 This introduces a problem in canonical when formats are not supported,
 where /type/aside/ redirects to /type/aside/?post_format=aside. In this
 specific case, Mark was actually registering support on init 10, which was
 too late for the core taxonomies at init 0. (Would need to happy on
 after_setup_theme.)

 Instead, we should always support rewriting, and let the query 404 the
 page as appropriate. Thus, /type/aside/ will 404 when there are no asides,
 whether formats are enabled or not, and whether the aside is a supported
 format or not.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16146>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list