[wp-trac] [WordPress Trac] #16132: Duplicate "try again" links when themes_api fails

[WordPress Trac]

#16132: Duplicate "try again" links when themes_api fails
--------------------------+-----------------------------
 Reporter:  solarissmoke  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Themes        |    Version:  3.1
 Severity:  minor         |   Keywords:
--------------------------+-----------------------------
 When the Themes API fails, for example when searching for themes (in my
 case because of timed out connection to wp.org, two "Try again" links are
 presented to the user.

 The issue is with this line in
 WP_Theme_Install_List_Table->prepare_items()

 {{{
 wp_die( $api->get_error_message() . '</p> <p class="hide-if-no-js"><a
 href="#" onclick="document.location.reload(); return false;">' . __( 'Try
 again' ) . '</a>' );
 }}}

 $api->get_error_message() already returns a try again link ( set by
 themes_api() ), but this line adds another one in addition. I suggest
 removing the latter? Also, there are no CSS rules of .hide-if-no-js on
 Error pages, so it doesn't do anything.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16132>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software