[wp-trac] [WordPress Trac] #16622: [17246] Breaks category exclusion

[WordPress Trac]

#16622: [17246] Breaks category exclusion
------------------------------------+--------------------
 Reporter:  markjaquith             |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  high                    |   Milestone:  3.1.1
Component:  Query                   |     Version:  3.1
 Severity:  critical                |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+--------------------

Comment (by ryan):

 pre_get_posts is an unreliable place to do set().  You are setting a query
 var after the query vars are parsed.  It happens to work for a few things
 in 3.0, but it isn't uniformly reliable.  It also don't set the query
 flags to match the query.   But, I guess these things have become
 features. :-)

 Anyhow, the patch seems a good approach. The query vars array is usually
 pretty small so I don't think the serialize will be a big hit.  Going
 forward, we might want to

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16622#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software