[wp-trac] [WordPress Trac] #11006: Theme Preview on Admin Page

WordPress Trac wp-trac at lists.automattic.com
Mon Dec 19 02:07:13 UTC 2011


#11006: Theme Preview on Admin Page
----------------------------+-------------------------
 Reporter:  AntonShevchuk   |       Owner:
     Type:  enhancement     |      Status:  closed
 Priority:  low             |   Milestone:
Component:  Administration  |     Version:  2.8.4
 Severity:  normal          |  Resolution:  worksforme
 Keywords:                  |
----------------------------+-------------------------
Changes (by nacin):

 * status:  new => closed
 * resolution:   => worksforme
 * milestone:  Future Release =>


Comment:

 There's not enough information here for me to go on.

 It also looks like an edge case: `wp_enqueue_style( 'constructor-custom-
 style', get_option('home').'/?theme-constructor=css');` means you're
 loading WordPress *again* just to generate CSS. This is bad.

 http://ottopress.com/2010/dont-include-wp-load-please/ (Use the Right Way
 the First, not the Second).

 You should probably just capture when it is a preview and add the query
 args yourself to the wp_enqueue_style() call.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11006#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list