[wp-trac] [WordPress Trac] #19471: Automatically support custom post types in category and tag archives

WordPress Trac wp-trac at lists.automattic.com
Thu Dec 8 17:13:51 UTC 2011


#19471: Automatically support custom post types in category and tag archives
--------------------------+------------------------------
 Reporter:  chrisbliss18  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Query         |     Version:  3.0
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by chrisbliss18):

 Replying to [comment:17 scribu]:
 > Replying to [comment:16 chrisbliss18]:
 > > The code reverted in [16505] was different than the patch I provided
 and has more far-reaching consequences.
 >
 > The code was different, but the intent was clear: don't set the post
 type to 'any' when categories and tags are involved, because this creates
 problems on some installs. So no, your patch is not appropriate.
 Can you give more details about these problems? Without knowing all the
 details, I don't know how it will be possible to create a patch that can
 avoid these landmines.

 > > I would think that the only difference between the use of "any" and a
 specifically-generated list of post types given the final query would be a
 possible query performance difference.
 >
 > The other difference is that it wouldn't affect sites that expect only
 'post' to be set. As I said before, you would have to explicitly enable
 it, either when defining your CPT or via
 register_taxonomy_for_object_type().
 >
 The "any" gets parsed into an array of types. Manually creating an array
 of post types results in an array of types. In both scenarios, an array of
 types would not be equivalent to just "post". So, I don't see any
 difference. Again, give details please.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19471#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list