[wp-trac] [WordPress Trac] #19420: get_blog_permalink() can cache either an HTTP or HTTPS link for the same post

WordPress Trac wp-trac at lists.automattic.com
Sat Dec 3 03:42:25 UTC 2011


#19420: get_blog_permalink() can cache either an HTTP or HTTPS link for the same
post
--------------------------+------------------------------
 Reporter:  mdawaffe      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Multisite     |     Version:  3.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by mdawaffe):

 Replying to [comment:2 nacin]:
 > It would be nice, perhaps, if we did a set_url_scheme() which sets the
 scheme to be whatever it should be if home_url() was called there. (Note,
 this isn't a function in core yet — #18017.)

 The current {{{is_ssl() && !is_admin()}}} check is a decent guess for
 {{{home_url()}}}, since you're always talking about the same domain.

 It seems harder to make a good guess about what scheme to use for
 {{{get_blog_permalink()}}}.  If I'm on https://one.example.com/, should
 {{{get_blog_permalink()}}} return "https://two.example.com/?p=1" or
 "http://two.example.com/?p=1"?

 Hence the filter :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19420#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list