[wp-trac] [WordPress Trac] #19371: As of 3.3beta2 WP_Admin_Bar no longer provides a way to access attributes of existing menu items

WordPress Trac wp-trac at lists.automattic.com
Thu Dec 1 00:25:07 UTC 2011


#19371: As of 3.3beta2 WP_Admin_Bar no longer provides a way to access attributes
of existing menu items
------------------------------+---------------------
 Reporter:  willshouse        |       Owner:  nacin
     Type:  defect (bug)      |      Status:  closed
 Priority:  high              |   Milestone:  3.3
Component:  Admin Bar         |     Version:  3.3
 Severity:  minor             |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by nacin):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [19501]:
 {{{
 #!CommitTicketReference repository="" revision="19501"
 Finalize the WP_Admin_Bar architecture for 3.3.
  * Introduce a get_node() method for plugins.
  * Deprecate $wp_admin_bar->menu. Plugins will need to use get_node(),
 remove_node(), add_node() to make modifications. This finalizes a
 backwards incompatible change made earlier in the cycle.
  * Allow add_node() to take a node object (which could come from
 get_node(), then be modified).
  * Ensure that our underlying storage (the nodes property) is private to
 core. Introduce _set_node, _unset_node, _get_nodes, get_nodes as the only
 ways to interface with this.
  * Protect and finalize _render_item, and _render_group. render() remains
 public and technically overridable, though I would discourage this of
 plugin authors.
  * Deprecate recursive_render(). Use render() or _render_item().

 More about the internals:
  * Late-binds a node's 'children' array.
  * Eliminates the root property, leverages a 'root' node.
  * Splits render() into _bind() and _render(), both protected and
 finalized.

 Fixes #19371.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19371#comment:24>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list