[wp-trac] [WordPress Trac] #18180: Missing i18n in setup-config.php

Tue Aug 30 00:07:50 UTC 2011

#18180: Missing i18n in setup-config.php
-------------------------+-----------------------
 Reporter:  CoenJacobs   |       Owner:  nacin
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  3.3
Component:  I18N         |     Version:  3.2.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Comment (by dd32):

 > Since we already have version.php included, couldn't we just use
 $wp_local_package if it's set?
 To be honest, I didn't even look at what that variable contains since I
 was developing this on a english-only install.
 > $text_direction is set in WP_LANG_DIR . "/$locale.php", so I guess we
 need to include that file if it exists.
 Ah, that's where it's set, I thought it might've been set through one of
 the helper functions - It's not really something that -needs- to be set
 through PHP to start with. The Internationalisation included was really
 bare-basics in that patch, it's not supposed to be a final clean patch,
 rather a draft of what we could do.
 > install.css is changed to install.dev.css. Is that intentional?
 That'd change when commited, the patch includes changes to the dev
 stylesheet, so for testing, simpler to include that
 > Do we actually need to allow apostrophes in DB_HOST?
 Lets leave that for #13839 - but it was purely a consistency thing.
 > Due to [18578], we need to set <body class="rtl"> in both setup-
 config.php and install.php if is_rtl(). We don't have that function in
 setup-config.php, so we can check $text_direction itself.
 We can include locale.php (Where that's set) most likely, however we don't
 have {{{language_attributes()}}} either, so the text direction needs to be
 set as well (not just the css class)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18180#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software