[wp-trac] [WordPress Trac] #17975: _default_wp_die_handler css referencing logic is fragile and doesn't always work

[WordPress Trac]

#17975: _default_wp_die_handler css referencing logic is fragile and doesn't always
work
-------------------------------------------------+-------------------------
 Reporter:  westi                                |       Owner:  westi
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  3.3
Component:  General                              |     Version:  3.2
 Severity:  normal                               |  Resolution:
 Keywords:  3.3-early westi-likes has-patch      |
  commit                                         |
-------------------------------------------------+-------------------------

Comment (by dd32):

 > maybe the installer should not use wp_die to displayerror messages and
 instead display the itself?

 I completely agree with you there actually, the validation errors should
 be inline, and i'll be attacking that in a seperate ticket shortly i
 think.

 That being said, The wp_die() instance I was refering to there comes
 directly from wpdb, and I expect a number of plugins which utilise
 wp_die() expect the h1 and button stylings at least.

 The suggested patch from me could be vastly simplified, instead, if it
 just checked for admin_url() being valid and enqueued the stylesheet then
 perhaps..

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17975#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software