[wp-trac] [WordPress Trac] #17197: Attach media - search results not populating

[WordPress Trac]

#17197: Attach media - search results not populating
--------------------------+-----------------------
 Reporter:  tomauger      |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:
Component:  General       |     Version:  3.1
 Severity:  minor         |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+-----------------------
Changes (by tomauger):

 * keywords:   => 2nd-opinion
 * status:  closed => reopened
 * resolution:  invalid =>


Comment:

 @nacin: not to be argumentative - obviously this is your call - but the
 issue I was reporting was less about the built in functions.php and
 whether it did or did not have a closing ?> tag. Though I appreciate your
 clarification on the reason behind leaving it out - makes sense!

 The issue is that the Search dialog box of the Attach feature in the Media
 Library stops working the moment any whitespace creeps into the .php
 include files. It's a very likely scenario that this will occur,
 particularly in child themes where the user is building the php files
 often from scratch themselves.

 The bottom line is: this Search feature is VERY likely to break and the
 reason is certainly not documented anywhere that's easily found (other
 than the one post on the forum where I documented my findings), so why not
 eliminate the issue?

 If the issue is extra whitespace creeping into the output of the Search
 results (which TBH doesn't make sense to me, since HTML chomps whitespace
 ordinarily), then why not run a quick RegExp that trims that whitespace
 before outputting? (eg: s/^\s*// to trim leading whitespace). Just putting
 an idea out there.

 Don't mark this as invalid - IMHO it's a valid bug because of the way the
 search results dialog was built - it's just low priority.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17197#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software