[wp-trac] [WordPress Trac] #16822: FORCE_SSL_LOGIN causes wp-login.php to have an incorrect https link

WordPress Trac wp-trac at lists.automattic.com
Thu Apr 7 06:04:16 UTC 2011


#16822: FORCE_SSL_LOGIN causes wp-login.php to have an incorrect https link
-------------------------------------+------------------------------
 Reporter:  dbvista                  |       Owner:  jakub.tyrcha
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Security                 |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------

Comment (by nacin):

 Do we actually need the `force_ssl_admin() || force_ssl_login()` check?  I
 imagine `! is_ssl()` is enough.

 Actually, I think the patch doesn't work right. In this case, you are
 viewing the page over SSL, but want http links. So that needs to be
 `is_ssl()`, not `!`.

 This makes me think further about set_url_scheme().

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16822#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list