[wp-trac] [WordPress Trac] #16303: Improve documentation and usability of WP_Rewrite Endpoint support

[WordPress Trac]

#16303: Improve documentation and usability of WP_Rewrite Endpoint support
-----------------------------------+--------------------
 Reporter:  westi                  |       Owner:  westi
     Type:  defect (bug)           |      Status:  new
 Priority:  lowest                 |   Milestone:  3.2
Component:  Rewrite Rules          |     Version:  3.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch westi-likes  |
-----------------------------------+--------------------

Comment (by westi):

 Replying to [comment:6 hakre]:
 > Additional notes:
 >
 >  * EP_ALL can be safely defined as 16 383, that spares the calculation.

 This was changed on purpose to ease maintenance and to hilight to people
 reading the code that it wasn't a static value and could change.

 >  * Same for EP_ALL_ARCHIVES, can be pre-calculated as well
 (documentation could show what value stands for)

 All "Archive" type pages

 >  * About the missing use of the define dd32 was pointing westi to I have
 no clue.

 The define is added but not used as it's really useful for plugins :)

 >
 > westi: WP_Rewrite::add_endpoint() had documented the `$places` as an
 array, you changed that to bitmask (and I to int because I think bitmasks
 are ints). What PHP vartype is that `$places` parameter of the said
 function?

 bitmasks are ints yes - I was just being more specific.

 Take note all the code in my original patch was written on a transatlantic
 flight :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16303#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software