[wp-trac] [WordPress Trac] #14915: Fix activation hook inconsistency

WordPress Trac wp-trac at lists.automattic.com
Tue Sep 21 01:16:08 UTC 2010


#14915: Fix activation hook inconsistency
--------------------------+-------------------------------------------------
 Reporter:  nacin         |       Owner:     
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.1
Component:  Plugins       |     Version:  2.9
 Severity:  normal        |    Keywords:     
--------------------------+-------------------------------------------------

Old description:

> The activation hook fires whenever a plugin is updated through the admin,
> but not during bulk updates.
>
> We need to resolve this inconsistency, and either A) fire activation
> hooks for bulk updates, or B) stop activation hooks from firing for
> single updates.
>
> I think I suggest (A), despite the backwards compatibility issue. It's
> unintuitive for an activation hook to be fired on update, and
> additionally it is not reliable due to manual updates (including SVN). As
> it is, we silence deactivation hooks on update.
>
> Related, a register_upgrade_hook() ticket #14912, that I believe should
> be wontfix'd. Schema updates require special handling at the plugin level
> IMO for now.

New description:

 The activation hook fires whenever a plugin is updated through the admin,
 but not during bulk updates.

 We need to resolve this inconsistency, and either A) fire activation hooks
 for bulk updates, or B) stop activation hooks from firing for single
 updates.

 I think I suggest (B), despite the backwards compatibility issue. It's
 unintuitive for an activation hook to be fired on update, and additionally
 it is not reliable due to manual updates (including SVN). As it is, we
 silence deactivation hooks on update.

 Related, a register_upgrade_hook() ticket #14912, that I believe should be
 wontfix'd. Schema updates require special handling at the plugin level IMO
 for now.

--

Comment(by nacin):

 Corrected, thanks.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14915#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list