[wp-trac] [WordPress Trac] #14786: WP_Http Transport test order refactoring

WordPress Trac wp-trac at lists.automattic.com
Mon Sep 6 18:03:37 UTC 2010


#14786: WP_Http Transport test order refactoring
--------------------------+-------------------------------------------------
 Reporter:  hakre         |       Owner:                        
     Type:  defect (bug)  |      Status:  new                   
 Priority:  normal        |   Milestone:  Awaiting Review       
Component:  HTTP          |     Version:  3.0.1                 
 Severity:  normal        |    Keywords:  has-patch dev-feedback
--------------------------+-------------------------------------------------

Comment(by jacobsantos):

 {{{
 if ( !call_user_func( array( $class, 'test' ), $args ) )
          continue;
 }}}

 Should be:

 {{{
 if( ! $class::test($args) )
         continue;
 }}}

 for performance. The syntax should work fine, but I haven't tested it.

 Also, the Method check in Fopen is wrong. The problem is not the method
 but sending with a body as part of the message. It is possible to send a
 body with GET requests.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14786#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list