[wp-trac] [WordPress Trac] #14993: make_clickable issue with ! character in URL

[WordPress Trac]

#14993: make_clickable issue with ! character in URL
--------------------------+-------------------------------------------------
 Reporter:  lancewillett  |       Owner:  westi    
     Type:  defect (bug)  |      Status:  accepted 
 Priority:  high          |   Milestone:  3.1      
Component:  Formatting    |     Version:  3.0.1    
 Severity:  major         |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by filosofo):

 Replying to [comment:25 westi]:
 > Committed filosofo's patch in [16111]
 >
 > Added extra tests in http://unit-tests.trac.wordpress.org/changeset/314
 >
 > It would still be nice to not link in the ! if after a url for emphasis
 as discussed above.

 OK, `make-clickable-twitter.14993.2.diff` makes it so the RFC 3986 sub-
 delims are ignored on either end of a URL, such as

   `This is a really good tweet
 http://twitter.com/#!/wordpress/status/25907440233!`

 ''except'' for a closing parenthesis ")" on the end, because from the WP
 tests the following is supposed to be the entire URL:

   `http://en.wikipedia.org/wiki/PC_Tools_(Central_Point_Software)`

 This nods to common practice rather than specification, and changing it
 would break backwards-compatibility.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14993#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software