[wp-trac] [WordPress Trac] #15606: Remove Hardcoded Image Extensions

WordPress Trac wp-trac at lists.automattic.com
Tue Nov 30 10:50:35 UTC 2010


#15606: Remove Hardcoded Image Extensions
---------------------------+------------------------------------------------
 Reporter:  acumensystems  |       Owner:                 
     Type:  enhancement    |      Status:  new            
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  General        |     Version:                 
 Severity:  normal         |    Keywords:                 
---------------------------+------------------------------------------------

Comment(by acumensystems):

 Hi - was that a question or a summary?

 To clarify - the "import" MIME type check was intentionally dropped. I
 have scanned the entire WP codebase, and can't find this (invalid) MIME
 type being set anywhere. So effectively this function would never
 thumbnail based on image extension, but only on a correct "image/xyz" MIME
 type. Most likely it was a hack for an early import function that failed
 to capture the MIME type from the browser upload.

 Dropping the check for this fake MIME type both simplifies the code but
 also ensures that files with image extensions can be thumbnailed.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15606#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list