[wp-trac] [WordPress Trac] #15193: get_file_data() regex issue

WordPress Trac wp-trac at lists.automattic.com
Fri Nov 5 22:45:13 UTC 2010


#15193: get_file_data() regex issue
--------------------------+-------------------------------------------------
 Reporter:  scribu        |        Owner:          
     Type:  defect (bug)  |       Status:  reopened
 Priority:  lowest        |    Milestone:  3.1     
Component:  Plugins       |      Version:          
 Severity:  trivial       |   Resolution:          
 Keywords:  has-patch     |  
--------------------------+-------------------------------------------------

Comment(by nacin):

 Replying to [comment:13 scribu]:
 > If we can knowingly break many plugins with #14915, I think we can also
 afford to potentially break a few plugins with extremely weird header
 definitions.
 We don't bargain like that. #14915 was a change deliberately made to fix
 an important inconsistency. Here, the fix for an extreme edge bug has the
 potential to introduce some much more noticeable bugs, like a plugin no
 longer being considered valid and thus deactivating itself.

 I'm asking for research, and potentially unit tests. A grep of "Plugin
 Name:" through the entire repo should show every preceding character in
 use, and patterns could be drawn.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15193#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list