[wp-trac] [WordPress Trac] #12774: Don't fire wp_notify_postauthor() when the author moderated the comment

WordPress Trac wp-trac at lists.automattic.com
Fri Nov 5 21:22:32 UTC 2010


#12774: Don't fire wp_notify_postauthor() when the author moderated the comment
------------------------------+---------------------------------------------
 Reporter:  nacin             |        Owner:          
     Type:  enhancement       |       Status:  reopened
 Priority:  normal            |    Milestone:  3.1     
Component:  Comments          |      Version:          
 Severity:  normal            |   Resolution:          
 Keywords:  has-patch commit  |  
------------------------------+---------------------------------------------
Changes (by nacin):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Didn't notice an issue with the logic in the patch until now:

 `( $user->user_id == $moderating_uid )`

 but:

  `$moderating_uid = (int) $user->id;`

 This should be:

 `$moderating_uid = $moderating_user->id;`

 Or even better, just get_current_user_id(), and we can clean this up a
 little in terms of standards.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12774#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list