[wp-trac] [WordPress Trac] #13231: Refactoring of custom header page

[WordPress Trac]

#13231: Refactoring of custom header page
----------------------------+-----------------------------------------------
 Reporter:  ocean90         |       Owner:           
     Type:  enhancement     |      Status:  new      
 Priority:  normal          |   Milestone:  3.0      
Component:  Administration  |     Version:  3.0      
 Severity:  normal          |    Keywords:  has-patch
----------------------------+-----------------------------------------------

Comment(by ocean90):

 Which bugs are fixed and changes are in my patch?
  - ''define('NO_HEADER_TEXT', false);'' doesn't work, it hides the button
 too, it shows only if the line is removed
  - You can only change the status/color of the header text if you have set
 a header image, why not without an image?
  - JS bugs ''hide_text not defined'' or ''container not defined''
  - Text color buttons are useless if javascript is disabled.
  - If the screen resolution is 1024x800 the layout will be broken, see
 http://grab.by/4yKf
  - ''display: none;'' for ''#headimg h1''' and '''#headimg #desc'' was
 needed, because WordPress doesn't have handled it itself and it should do
 it.
  - Same for ''#headimg'' styling. Because of that the layout can be
 broken, see above, WordPress should handle this by itself.
  - It is not possible to reset the image to the original image only if
 ''empty($this->default_headers) == true'', but the orignal image should be
 ''HEADER_IMAGE''.
  - Do not use ''remove_theme_mods()'', because it removes ALL theme mods.
  - A table for default headers is not flexible enough, it can break the
 layout too, see above.
  - Wrong page title "Your Header Image", you cannot only customize the
 image also the text.
  - And at least the layout: Current is http://grab.by/4yMF and with my
 patch it will look like this http://grab.by/4yMM

 ----
 ''Will themes have to update their admin header style callbacks?''

 If they only changed the color/font-style no, if the changed positions
 then perhaps, but I think if they want to change the position or something
 else like that, they should better use ''admin_image_div_callback'', that
 would be saver. But I could try to improve this point.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13231#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software