[wp-trac] [WordPress Trac] #13231: Refactoring of custom header page

[WordPress Trac]

#13231: Refactoring of custom header page
----------------------------+-----------------------------------------------
 Reporter:  ocean90         |       Owner:           
     Type:  enhancement     |      Status:  new      
 Priority:  normal          |   Milestone:  3.0      
Component:  Administration  |     Version:  3.0      
 Severity:  normal          |    Keywords:  has-patch
----------------------------+-----------------------------------------------

Comment(by nacin):

 I've looked over this. I like it, but it introduces some new complexity.

 First, we should entirely scrap transparency. Way too close to release for
 that, it should be saved for 3.1.

 The image preview is cut off. If we remove all but the width attribute
 from .appearance_page_custom-header #headimg img (and thus, only have
 width:100% and no absolute positioning) and remove the calculated height
 from #headimg, then the image will scale to the width of the page.

 NO_HEADER_TEXT should probably be a true/false check, not a defined check.
 Perhaps we define it as false if it isn't defined, early on, and then we
 can simply assess NO_HEADER_TEXT throughout.

 Remove the CDATA blocks -- #11939.

 Also, in the future, it may be a good idea to ignore whitespace for lines
 that aren't changed when doing major refactoring -- it is much more
 difficult to analyze. Better to do that as a follow-up.

 Overall, some very good improvements here. After saying it for a week, I
 would really like to check this in soon.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13231#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software